-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor swarm dialing logic #38
Conversation
A basic idea of the change: |
when reviewing this, i recommend looking over the changes in swarm_dial.go, particularly in |
a82dcac
to
d7121bf
Compare
*/ | ||
|
||
////// TEMP UNTIL PEERSTORE GETS UPGRADED | ||
// Ref: https://github.com/ipfs/go-libp2p-peer/pull/1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for tracking issue ❤️
Just a few comments and getting CI to pass -- otherwise LGTM 🐴! Lots of good godocs and thorough tests! |
010f3a5
to
2247f1c
Compare
2247f1c
to
9edbb2d
Compare
Take eventbus events to completion
refactor swarm dialing logic
don't backoff dialing when the context is canceled
chore: remove inline interface
Fix missing transport parameter in dialed connection
Make sure we actually read and write as much data as we expect
stop using goprocess for shutdown
Replace b58-encoded keys with b32 (no padding) + test against multiple ds. Resolves #38.
This happens when empty sub-scopes are moved around between scopes.
No description provided.